Repository navigation
Replace --disallow-any flags with separate boolean flags. - #4178
Merged
Merged
Conversation
This PR also gets rid of `--disallow-any=unannotated` because it is the same thing as `--disallow-untyped-defs`. Fix python#4089
gvanrossum
reviewed
Oct 30, 2017
gvanrossum
left a comment
gvanrossum
left a comment
Member
There was a problem hiding this comment.
Beautiful! I have a few new nits on the help strings, will post later.
gvanrossum
reviewed
Oct 30, 2017
| parser.add_argument('--disallow-any-unimported', default=False, action='store_true', | ||
| help="disallow usage of types that come from unfollowed imports") | ||
| parser.add_argument('--disallow-any-expr', default=False, action='store_true', | ||
| help='disallow all expressions in the module that have type Any') |
Member
There was a problem hiding this comment.
I'd drop "in the module" since that's implicit (and you don't say it for the other flags).
| help="disallow various types of Any in a module. Takes a comma-separated " | ||
| "list of options (defaults to all options disabled)") | ||
| parser.add_argument('--disallow-any-unimported', default=False, action='store_true', | ||
| help="disallow usage of types that come from unfollowed imports") |
Member
There was a problem hiding this comment.
Maybe "disallow Any types resulting from unfollowed imports" ?
Collaborator
Author
There was a problem hiding this comment.
Yep, this seems reasonable! Done!
Member
|
Thanks! Now I have a whole bunch of internal mypy.ini files to clean up... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR also gets rid of
--disallow-any=unannotatedbecause itis the same thing as
--disallow-untyped-defs.Fix #4089